Skip to content

Ramsundar - Fix: Admin/owner timer submission contaminating another user's timelog display#5245

Open
Ram-blip wants to merge 1 commit into
developmentfrom
Ramsundar-fix-timelog-owner-state-mismatch
Open

Ramsundar - Fix: Admin/owner timer submission contaminating another user's timelog display#5245
Ram-blip wants to merge 1 commit into
developmentfrom
Ramsundar-fix-timelog-owner-state-mismatch

Conversation

@Ram-blip
Copy link
Copy Markdown
Contributor

@Ram-blip Ram-blip commented May 8, 2026 •
edited by one-community
Loading

Description

Screenshot 2025-07-11 at 11 30 30 PM Screenshot 2025-07-11 at 11 30 40 PM

Video Link: https://www.loom.com/share/5e27c7b0b61144d68c433044c7e97350?sid=60bac4c4-4432-4fd9-84c6-cd1a9447df30

Watch the video to get more idea about the bug.

Related PRS (if any):

This PR is a redo and integration of all the feedback given on this PR: #3742

Main changes explained:

Before:
You're on User B's timelog page, but when you log time:

  • You (admin) log time via the Timer while viewing UserB's(Volunteer) timelog page
  • User B's "Current Week" shows your logged time (ex: 0.53hrs) instead of their time
  • Refresh fixes it because it reloads the correct data from the server

After:

  • You (admin) log time via the Timer while viewing UserB's timelog page
  • After submit, the time entry is still correctly saved on the backend for you
  • UserB's page continues showing UserB's own entries undisturbed
  • When you navigate to your own dashboard/timelog, you'll see your entry there

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin/owner user
  5. go to dashboard
  6. Start timer -> Click any other teammate timelog
  7. In another teammate's timelog, log your time and check if your own "Current Week" is showing there.

Screenshots or videos of changes:

Loom Video After:
https://www.loom.com/share/bd41aa0996b74abdb83946bb2ccb79c1

Note:

This is a clean PR related to 3742 which had some node issues, so i have closed it and created a new fix for this!

@netlify
Copy link
Copy Markdown

netlify Bot commented May 8, 2026 •
edited
Loading

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit aa519bc
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69fdc77a8d4546000827f1df
😎 Deploy Preview https://deploy-preview-5245--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@one-community one-community mentioned this pull request May 9, 2026
Closed
DeepighaJ
DeepighaJ requested changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown

@DeepighaJ DeepighaJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
I tried to run PR locally and logged in as Owner Account.
The project/Task selection dropdown doesnt have values to select and notes is disable too. Not able to submit without those mandatory field. Tried to do this is another uses timelog and admin dashboard. It's same everywhere.
Image
Image
Image

@Ram-blip
Copy link
Copy Markdown
Contributor Author

Ram-blip commented May 12, 2026

Hi I tried to run PR locally and logged in as Owner Account. The project/Task selection dropdown doesnt have values to select and notes is disable too. Not able to submit without those mandatory field. Tried to do this is another uses timelog and admin dashboard. It's same everywhere. Image Image Image

Hey Deephiga,

It works for me. I think the owner account you're using might not have any projects assigned. If you have projects assigned to you, then only it allows you to pick one.

The expected behavior is: you pick a project first, and then the notes section becomes editable.

Thanks,
Ram

Screenshot 2026-05-12 at 12 55 26 PM Screenshot 2026-05-12 at 12 56 13 PM

@Ram-blip Ram-blip requested a review from DeepighaJ May 12, 2026 07:28
DeepighaJ
DeepighaJ approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown

@DeepighaJ DeepighaJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
I checked out the current branch and ran it locally. Logging into an Owner account and submitting time from a different user's activity page worked as expected: the time was credited to the Owner account and not the other user.
Image
Image
Image
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeepighaJ DeepighaJ DeepighaJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ram-blip @DeepighaJ